[ 
https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504425#comment-15504425
 ] 

ASF GitHub Bot commented on CB-11776:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/491
  
    ## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/491?src=pr) is 80.37% 
(diff: 100%)
    > Merging [#491](https://codecov.io/gh/apache/cordova-lib/pull/491?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will not change coverage
    
    ```diff
    @@             master       #491   diff @@
    ==========================================
      Files            67         67          
      Lines          5183       5183          
      Methods         835        835          
      Messages          0          0          
      Branches       1005       1005          
    ==========================================
      Hits           4166       4166          
      Misses         1017       1017          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last update 
[f8b58c7...7b1354a](https://codecov.io/gh/apache/cordova-lib/compare/f8b58c782c71558516adbbd81929ee31ec3ded7f...7b1354ac0090a36133f7fb742fb2090673e200d5?src=pr)


> Can't add two plugins with different edit-config targets
> --------------------------------------------------------
>
>                 Key: CB-11776
>                 URL: https://issues.apache.org/jira/browse/CB-11776
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaCommon
>    Affects Versions: 1.4.0
>            Reporter: Karen Tran
>            Assignee: Karen Tran
>              Labels: edit-config, triaged
>             Fix For: Master
>
>
> When adding two plugins where both plugins are using edit-config, the second 
> plugin will have issues being added. The conflict checking for edit-config is 
> missing a case where the target cannot resolve to an existing target. Should 
> check if the target exists before proceeding. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to