[
https://issues.apache.org/jira/browse/CB-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581833#comment-15581833
]
ASF GitHub Bot commented on CB-11933:
-------------------------------------
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-windows/pull/202
CB-11933: Remove capabilities from manifest
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### What does this PR do?
Windows has special logic for appxmanifest's capabilities removal,
therefore we should override this behaviour
### What testing has been done on this change?
Auto test
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-windows CB-11933
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/202.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #202
----
commit 48631129813d870bdfbaaaef8468f65f4de2f5b4
Author: Nikita Matrosov <matrosov.nikit...@gmail.com>
Date: 2016-10-17T10:20:37Z
CB-11933: Remove capabilities from manifest
Windows has special logic for appxmanifest's capabilities removal,
therefore we should override this behaviour
----
> [windows] uap: not added on plugin add
> --------------------------------------
>
> Key: CB-11933
> URL: https://issues.apache.org/jira/browse/CB-11933
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Sergey Shakhnazarov
> Assignee: Nikita Matrosov
>
> {noformat}
> cordova create test
> cd test
> cordova platform add https://github.com/apache/cordova-windows
> cordova plugin add
> https://github.com/AzureAD/azure-activedirectory-library-for-cordova
> cordova plugin add plugins\cordova-plugin-ms-adal\src\windows\sso\
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> ->
> {noformat}
> <Capabilities>
> <Capability Name="internetClient" />
> <Capability Name="enterpriseAuthentication" />
> <Capability Name="privateNetworkClientServer" />
> <Capability Name="sharedUserCertificates" />
> </Capabilities>
> {noformat}
> {{cordova prepare}}
> {noformat}
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> {noformat}
> <Capabilities>
> <Capability Name="internetClient" />
> <uap:Capability Name="enterpriseAuthentication" />
> <Capability Name="privateNetworkClientServer" />
> <uap:Capability Name="sharedUserCertificates" />
> </Capabilities>
> {noformat}
> {{cordova plugin rm cordova-plugin-ms-adal-sso}}
> {noformat}
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> {noformat}
> <Capabilities>
> <Capability Name="internetClient" />
> <uap:Capability Name="enterpriseAuthentication" />
> <uap:Capability Name="sharedUserCertificates" />
> </Capabilities>
> {noformat}
> 1. uap: prefixes not being added on plugin add
> 2. cordova prepare fixes this
> 3. plugin rm does not remove added capabilities as they have been changed
> cordova-plugin-ms-adal-sso plugin.xml:
> {noformat}
> <platform name="windows">
> <js-module name="overrides" src="www/overrides.js">
> <runs />
> </js-module>
> <config-file target="package.appxmanifest"
> parent="/Package/Capabilities" device-target="windows">
> <Capability Name="enterpriseAuthentication" />
> <Capability Name="privateNetworkClientServer" />
> <Capability Name="sharedUserCertificates" />
> </config-file>
> </platform>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
