[ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613455#comment-15613455
 ] 

ASF GitHub Bot commented on CB-3232:
------------------------------------

GitHub user sterlingann opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/195

    Cb 6229

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Gives the developer the ability to either show or hide the edit text 
containing the url as well as the toolbar buttons.
    
    ### What testing has been done on this change?
    Tested all combinations of 'yes' and 'no' values for both location and 
toolbar.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sterlingann/cordova-plugin-inappbrowser 
CB-6229

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #195
    
----
commit 16cd8d1f8457982dce646e145a2781d565dafc62
Author: Sterling <[email protected]>
Date:   2016-10-26T23:33:02Z

    updated to give developers option of hiding the url in the toolbar

commit 383a0f8634103b6c835339bd00e1fb11f38874ef
Author: Sterling <[email protected]>
Date:   2016-10-27T22:04:23Z

    added functionality of showing/hiding the toolbar buttons

----


> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>
>                 Key: CB-3232
>                 URL: https://issues.apache.org/jira/browse/CB-3232
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry, CLI
>    Affects Versions: 2.7.0
>            Reporter: Michael Brooks
>            Assignee: Michael Brooks
>             Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to