[
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622269#comment-15622269
]
ASF GitHub Bot commented on CB-3232:
------------------------------------
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-windows/pull/207
Move windows-specific logic from cordova-common
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### What does this PR do?
This PR moves windows-specific logic from cordova-common to
cordova-windows. This logic is associated with demuxing 'package.appxmanifest'
into relevant platform-specific appx manifests. Also auto-test was moved and
edited according changes.
### What testing has been done on this change?
Auto test
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-windows
remove-windows-logic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #207
----
commit b101deda784bfdb3ad45c2f86b830c6cc356a72b
Author: Nikita Matrosov <[email protected]>
Date: 2016-10-31T13:57:24Z
Move windows-specific logic from cordova-common
----
> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>
> Key: CB-3232
> URL: https://issues.apache.org/jira/browse/CB-3232
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry, CLI
> Affects Versions: 2.7.0
> Reporter: Michael Brooks
> Assignee: Michael Brooks
> Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating
> BlackBerry project...
> Updating config.xml ...
> sed:
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
> No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application
> directory!
> ]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
