[
https://issues.apache.org/jira/browse/CB-12132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656423#comment-15656423
]
ASF GitHub Bot commented on CB-12132:
-------------------------------------
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
CB-12132: (android & ios) implement hidenotclose feature
### Platforms affected
android & ios
### What does this PR do?
This adds a new option hidenotclose which can be passed to the
inappbrowser.
When set to yes the done button on iOS or the X button android will
hide the web view instead of closing it.
This allows the user to show/hide the web view multiple times without
having to reload the content and you can clean up when you know they
are done by calling close once.
### What testing has been done on this change?
manually tested on both android and ios with both enabled and disabled
settings.
when disabled (as by default) existing behaviour is maintained
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [O] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ghenry22/cordova-plugin-inappbrowser
hide_not_close
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #197
----
commit ec563a7af77e9f74cc73be8fd1a606946d4b4809
Author: ghenry22 <ghenr...@gmail.com>
Date: 2016-11-11T07:39:35Z
CB-12132: (android & ios) implement hidenotclose feature
This adds a new option hidenotclose which can be passed to the
inappbrowser.
When set to yes the done button on iOS or the X button android will
hide the web view instead of closing it.
This allows the user to show/hide the web view multiple times without
having to reload the content and you can clean up when you know they
are done by calling close once.
----
> Add hidenotcloseoption
> ----------------------
>
> Key: CB-12132
> URL: https://issues.apache.org/jira/browse/CB-12132
> Project: Apache Cordova
> Issue Type: New Feature
> Components: Plugin InAppBrowser
> Reporter: Gaven Henry
> Priority: Minor
> Labels: features
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> add a new option for android and ios:
> option: hidenotclose=yes
> this makes the done button on iOS or the X button android hide the
> inappbrowser webview instead of closing and destroying it.
> this is useful when doing something like:
> load a webview hidden (so it's nice and preloaded for the user)
> use the show() method when the user clicks to see it
> use the done/X button to hide the window
> call the close() method when done to clean up
> this allows us to start pre-loading the data, open and close the window
> multiple times without having to reload and then to call close when done to
> dispose of the view and clean up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
