[
https://issues.apache.org/jira/browse/CB-12132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15659198#comment-15659198
]
Gaven Henry commented on CB-12132:
----------------------------------
The new methods follow what is implemented for close, where there are 2 close
methods, one designed for the user to call and one for use with a selector that
the done button will hit.
In order to have minimal changes to the existing code and keep the logic
consistent I have implemented the same for the hide method. You can just reuse
the existing hide method as it expects a parameter which cannot be passed when
it is used as a selector. Hence the 2 close methods as well.
The browserHide method is implemented in line with the browserExit method again
for consistent behaviour. While there is some code duplication it seems that
it is necessary because of the different use cases, or called as selector vs
called by user from javascript.
I have implemented for iOS and android, I could possibly do windows as well but
I don't have the devices to test other platforms.
On Sat, Nov 12, 2016 at 7:45 AM +0800, "ASF GitHub Bot (JIRA)"
<j...@apache.org> wrote:
[
https://issues.apache.org/jira/browse/CB-12132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658541#comment-15658541
]
ASF GitHub Bot commented on CB-12132:
-------------------------------------
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
The existing hide and the new browserHide do exactly the same, can you make
the old hide just call browserHide instead of duplicating code.
Can you try adding this to other platforms too?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
> Add hidenotcloseoption
> ----------------------
>
> Key: CB-12132
> URL: https://issues.apache.org/jira/browse/CB-12132
> Project: Apache Cordova
> Issue Type: New Feature
> Components: Plugin InAppBrowser
> Reporter: Gaven Henry
> Priority: Minor
> Labels: features
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> add a new option for android and ios:
> option: hidenotclose=yes
> this makes the done button on iOS or the X button android hide the
> inappbrowser webview instead of closing and destroying it.
> this is useful when doing something like:
> load a webview hidden (so it's nice and preloaded for the user)
> use the show() method when the user clicks to see it
> use the done/X button to hide the window
> call the close() method when done to clean up
> this allows us to start pre-loading the data, open and close the window
> multiple times without having to reload and then to call close when done to
> dispose of the view and clean up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
