[
https://issues.apache.org/jira/browse/CB-11243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657279#comment-15657279
]
ASF GitHub Bot commented on CB-11243:
-------------------------------------
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-ios/pull/277
CB-11243: Fix target-device and deployment-target preferences
### Platforms affected
iOS
### What does this PR do?
Fixes target-device and deployment-target preferences. There are several
bugs reporting this issue.
[CB-11243](https://issues.apache.org/jira/browse/CB-11243)
[CB-11399](https://issues.apache.org/jira/browse/CB-11399)
[CB-11772](https://issues.apache.org/jira/browse/CB-11772)
[CB-11732](https://issues.apache.org/jira/browse/CB-11732)
This change adds `IPHONEOS_DEPLOYMENT_TARGET` and `TARGETED_DEVICE_FAMILY`
back to the project file. This is necessary for the preferences to work until
[CB-11468](https://issues.apache.org/jira/browse/CB-11468) is completed.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson/cordova-ios CB-11243
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #277
----
commit 73c7bf92b14cf27cc66595bad1325b18e456c3eb
Author: Connor Pearson <[email protected]>
Date: 2016-11-11T14:17:19Z
CB-11243: target-device and deployment-target were being ignored
----
> Target-device=handset also includes ipad values in plist and binary while
> submitting build
> ------------------------------------------------------------------------------------------
>
> Key: CB-11243
> URL: https://issues.apache.org/jira/browse/CB-11243
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: I am using visual studio tools for apache cordova
> Reporter: Shahbaz Khan
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I am using cordova cli version 6.1.1
> Even while selecting target-device='handset', i got error message in itunes
> submission that my binary contains ipad files and please upload ipad
> screenshots.
> Another thing is, I also checked plist file which also have the ipad configs
> even after selecting handset.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
