[
https://issues.apache.org/jira/browse/CB-11243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658726#comment-15658726
]
ASF GitHub Bot commented on CB-11243:
-------------------------------------
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/278
CB-11243 - Added failing tests
### Platforms affected
iOS
### What does this PR do?
Added failing tests for `target-device` and `deployment-target` preferences
on cordova-ios.
### What testing has been done on this change?
`npm run unit-tests`
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios PR_277_TEST
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #278
----
commit 7fb6480e83a4bfbcb42d979234defccfcf639f5f
Author: Shazron Abdullah <[email protected]>
Date: 2016-11-12T01:21:13Z
Added tests for cordova-ios PR 277
----
> Target-device=handset also includes ipad values in plist and binary while
> submitting build
> ------------------------------------------------------------------------------------------
>
> Key: CB-11243
> URL: https://issues.apache.org/jira/browse/CB-11243
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Environment: I am using visual studio tools for apache cordova
> Reporter: Shahbaz Khan
> Assignee: Shazron Abdullah
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I am using cordova cli version 6.1.1
> Even while selecting target-device='handset', i got error message in itunes
> submission that my binary contains ipad files and please upload ipad
> screenshots.
> Another thing is, I also checked plist file which also have the ipad configs
> even after selecting handset.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
