[
https://issues.apache.org/jira/browse/CB-12132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15721851#comment-15721851
]
ASF GitHub Bot commented on CB-12132:
-------------------------------------
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90834795
--- Diff: README.md ---
@@ -131,6 +132,7 @@ instance, or the system browser.
- __presentationstyle__: Set to `pagesheet`, `formsheet` or
`fullscreen` to set the [presentation
style](http://developer.apple.com/library/ios/documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalPresentationStyle)
(defaults to `fullscreen`).
- __transitionstyle__: Set to `fliphorizontal`, `crossdissolve` or
`coververtical` to set the [transition
style](http://developer.apple.com/library/ios/#documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalTransitionStyle)
(defaults to `coververtical`).
- __toolbarposition__: Set to `top` or `bottom` (default is `bottom`).
Causes the toolbar to be at the top or bottom of the window.
+ - __hidenotclose__: set to 'yes' to make the done/close button hide
the browser window rather than closing the browser (defaults to 'no')
--- End diff --
yeah, it's for both, but the preference is documented for both too, so in
the iOS section it should say "done" and in the Android section it should say
"close" instead of saying "done/close" on both
> Add hidenotcloseoption
> ----------------------
>
> Key: CB-12132
> URL: https://issues.apache.org/jira/browse/CB-12132
> Project: Apache Cordova
> Issue Type: New Feature
> Components: Plugin InAppBrowser
> Reporter: Gaven Henry
> Priority: Minor
> Labels: features
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> add a new option for android and ios:
> option: hidenotclose=yes
> this makes the done button on iOS or the X button android hide the
> inappbrowser webview instead of closing and destroying it.
> this is useful when doing something like:
> load a webview hidden (so it's nice and preloaded for the user)
> use the show() method when the user clicks to see it
> use the done/X button to hide the window
> call the close() method when done to clean up
> this allows us to start pre-loading the data, open and close the window
> multiple times without having to reload and then to call close when done to
> dispose of the view and clean up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
