ASF GitHub Bot commented on CB-12132:

Github user jcesarmobile commented on a diff in the pull request:

    --- Diff: README.md ---
    @@ -114,6 +114,7 @@ instance, or the system browser.
         - __hardwareback__: set to `yes` to use the hardware back button to 
navigate backwards through the `InAppBrowser`'s history. If there is no 
previous page, the `InAppBrowser` will close.  The default value is `yes`, so 
you must set it to `no` if you want the back button to simply close the 
         - __mediaPlaybackRequiresUserAction__: Set to `yes` to prevent HTML5 
audio or video from autoplaying (defaults to `no`).
         - __shouldPauseOnSuspend__: Set to `yes` to make InAppBrowser WebView 
to pause/resume with the app to stop background audio (this may be required to 
avoid Google Play issues like described in 
    +    - __hidenotclose__: set to 'yes' to make the done/close button hide 
the browser window rather than closing the browser (defaults to 'no')
    --- End diff --
    change done/close to just close as the done button is for iOS

> Add hidenotcloseoption
> ----------------------
>                 Key: CB-12132
>                 URL: https://issues.apache.org/jira/browse/CB-12132
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: Plugin InAppBrowser
>            Reporter: Gaven Henry
>            Priority: Minor
>              Labels: features
>   Original Estimate: 24h
>  Remaining Estimate: 24h
> add a new option for android and ios:
> option: hidenotclose=yes
> this makes the done button on iOS or the X button android hide the 
> inappbrowser webview instead of closing and destroying it.
> this is useful when doing something like:
> load a webview hidden (so it's nice and preloaded for the user)
> use the show() method when the user clicks to see it
> use the done/X button to hide the window
> call the close() method when done to clean up
> this allows us to start pre-loading the data, open and close the window 
> multiple times without having to reload and then to call close when done to 
> dispose of the view and clean up.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to