[
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736643#comment-15736643
]
ASF GitHub Bot commented on CB-3232:
------------------------------------
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-medic/pull/106
Appium updates
Please review @alsorokin !
### Platforms affected
iOS and Android
### What does this PR do?
Fixes and cleans up certain interactions with appium:
- Appium version bumped
- Desired capabilities in Selenium-land (and thus Appium) is usually
tricky and obtuse. Clarified some usage of it as well as forcing string for
`platformVersion`. Removed `browserName` completely as it is not applicable to
hybrid apps.
- I removed the `setTimeout`s around process killing, as on my Mac w/ node
v6.9.1 that would lead to improper termination of the appium process. I defer
to you, @alsorokin, on whether that is a good change or not.
### What testing has been done on this change?
Tested on Android 5.1 emulator w/ contacts plugin appium tests.
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/filmaj/cordova-medic appium-updates
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-medic/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit 1b57f67125584cf5acc91e94b8208fc2a8e7c936
Author: filmaj <[email protected]>
Date: 2016-12-09T23:04:48Z
Dont use browsername in selenium capabilities - not applicable for hybrid
apps.
commit 1309e6c3b1cf7ff3a70bff4e9f117ff6469f0bc4
Author: filmaj <[email protected]>
Date: 2016-12-09T23:13:08Z
Bumping appium to 1.5.3 (waiting on move to 1.6.x for when 1.6.3 comes out
commit 558d4bd95295a9712d71910b5b5db7df2d311c3b
Author: filmaj <[email protected]>
Date: 2016-12-09T23:14:59Z
Slight detail expansion on usage instructions. Adding a `--verbose` flag to
dump out appium outputs to the log. Capabilities: appium no longer uses
`--avd`, so remove it. Always force platformVersion to a string. A few extra
logs added for clarity of flow. Removed settimeouts on process killing (noticed
it would not clean up appium properly with them in place).
----
> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>
> Key: CB-3232
> URL: https://issues.apache.org/jira/browse/CB-3232
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry, CLI
> Affects Versions: 2.7.0
> Reporter: Michael Brooks
> Assignee: Michael Brooks
> Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating
> BlackBerry project...
> Updating config.xml ...
> sed:
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
> No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application
> directory!
> ]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
