[ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736661#comment-15736661
 ] 

ASF GitHub Bot commented on CB-3232:
------------------------------------

GitHub user filmaj opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/143

    Jasmine use of `afterAll` and label tweaks 

    ### Platforms affected
    
    iOS and Android
    
    ### What does this PR do?
    
    Instead of encapsulating teardown functionality into a jasmine test case 
via `it`, use the `afterAll` teardown function to specify one-time cleanup 
tasks.
    
    ### What testing has been done on this change?
    
    Tested on Android 5.1 emulator.
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/filmaj/cordova-plugin-contacts 
appium-test-tweaks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #143
    
----
commit 0153e093689db952846621fc14fa2bd7f17cfd49
Author: filmaj <maj....@gmail.com>
Date:   2016-12-09T23:22:35Z

    Pulled out appium session destruction into a jasmine `afterAll` teardown 
function (instead of its own test). Tweaking some labels.

----


> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>
>                 Key: CB-3232
>                 URL: https://issues.apache.org/jira/browse/CB-3232
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry, CLI
>    Affects Versions: 2.7.0
>            Reporter: Michael Brooks
>            Assignee: Michael Brooks
>             Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to