[
https://issues.apache.org/jira/browse/CB-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15744748#comment-15744748
]
ASF GitHub Bot commented on CB-12239:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/217
CB-12239 Add buildFlag option similar to iOS
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### What does this PR do?
This PR adds `buildFlag` CLI argument and corresponding option for
`build.json` file (similar to iOS) to allow users to pass arbitrary options
directly to MSBuild
### What testing has been done on this change?
Added new tests, ran unit and e2e tests
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-windows
build-flags-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #217
----
commit 6308e6974f5499857254fb79c91ded422b46486f
Author: Vladimir Kotikov <[email protected]>
Date: 2016-12-12T15:45:51Z
CB-12239 Add buildFlag option similar to iOS
----
> Allow passing build flags to MSBuild
> ------------------------------------
>
> Key: CB-12239
> URL: https://issues.apache.org/jira/browse/CB-12239
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: buildFlag, triaged, windows
>
> Similar to iOS (see CB-11952 and CB-12127) it'd be great if developers could
> pass arbitrary build flags to MSBuild. This is particularily useful for those
> who wants their app that contains plugins w/ native code to be compiled w/
> specific version of C++ build toolset (or if the plugin specifies toolset
> that is not available on build machine)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
