[
https://issues.apache.org/jira/browse/CB-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748309#comment-15748309
]
ASF GitHub Bot commented on CB-12239:
-------------------------------------
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/217#discussion_r92389331
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile,
buildType, buildarch, o
'/p:Configuration=' + buildType,
'/p:Platform=' + buildarch];
- if (otherConfigProperties) {
- var keys = Object.keys(otherConfigProperties);
- keys.forEach(function(key) {
- args.push('/p:' + key + '=' + otherConfigProperties[key]);
--- End diff --
Has this code moved? Or don't we need to prefix keys with `/p` anymore?
> Allow passing build flags to MSBuild
> ------------------------------------
>
> Key: CB-12239
> URL: https://issues.apache.org/jira/browse/CB-12239
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: buildFlag, triaged, windows
>
> Similar to iOS (see CB-11952 and CB-12127) it'd be great if developers could
> pass arbitrary build flags to MSBuild. This is particularily useful for those
> who wants their app that contains plugins w/ native code to be compiled w/
> specific version of C++ build toolset (or if the plugin specifies toolset
> that is not available on build machine)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
