[
https://issues.apache.org/jira/browse/CB-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751318#comment-15751318
]
ASF GitHub Bot commented on CB-12238:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/218#discussion_r92604767
--- Diff: cordova-js-src/splashscreen.js ---
@@ -203,10 +212,30 @@ function enableUserInteraction() {
document.body.style['-ms-content-zooming'] = origZooming;
}
+// Make title bg color match splashscreen bg color
+function colorizeTitleBar() {
+ var appView =
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
+ if (appView.titleBar) {
+ titleInitialBgColor = appView.titleBar.backgroundColor;
+
+ appView.titleBar.backgroundColor = titleBgColor;
+ appView.titleBar.buttonBackgroundColor = titleBgColor;
+ }
+}
+
+// Revert title bg color
+function revertTitleBarColor() {
+ var appView =
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
+ if (appView.titleBar) {
--- End diff --
Is this guaranteed that title bar would exist when you're leaving
fullscreen? otherwise you may end up not reverting title bar color due to this
condition. I'm mostly speculating and trying to find really edge cases, but
still.
Perhaps might be better to subscribe to
[`ApplicationView.VisibleBoundsChanged`](https://msdn.microsoft.com/en-us/library/windows/apps/windows.ui.viewmanagement.applicationview.visibleboundschanged.aspx)
and revert the color in the handler?
> [Windows] Colorize titlebar to match splash bg color
> ----------------------------------------------------
>
> Key: CB-12238
> URL: https://issues.apache.org/jira/browse/CB-12238
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
> Labels: splashscreen, triaged, windows
>
> 8.1/10 title bar color should match splashscreen background color - otherwise
> there is a kind of flashing to the white/accent color when extended splash is
> shown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
