[ 
https://issues.apache.org/jira/browse/CB-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15761540#comment-15761540
 ] 

ASF GitHub Bot commented on CB-12238:
-------------------------------------

Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/218#discussion_r93060350
  
    --- Diff: cordova-js-src/splashscreen.js ---
    @@ -203,10 +212,30 @@ function enableUserInteraction() {
         document.body.style['-ms-content-zooming'] = origZooming;
     }
     
    +// Make title bg color match splashscreen bg color
    +function colorizeTitleBar() {
    +    var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
    +    if (appView.titleBar) {
    +        titleInitialBgColor = appView.titleBar.backgroundColor;
    +
    +        appView.titleBar.backgroundColor = titleBgColor;
    +        appView.titleBar.buttonBackgroundColor = titleBgColor;
    +    }
    +}
    +
    +// Revert title bg color
    +function revertTitleBarColor() {
    +    var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
    +    if (appView.titleBar) {
    --- End diff --
    
    The change only affects desktop projects and this check for 
`appView.titleBar` is for Windows 8.1 OS only where titlebar isn't supported 
(store apps are shown without chrome).


> [Windows] Colorize titlebar to match splash bg color
> ----------------------------------------------------
>
>                 Key: CB-12238
>                 URL: https://issues.apache.org/jira/browse/CB-12238
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>              Labels: splashscreen, triaged, windows
>
> 8.1/10 title bar color should match splashscreen background color - otherwise 
> there is a kind of flashing to the white/accent color when extended splash is 
> shown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to