[
https://issues.apache.org/jira/browse/CB-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766900#comment-15766900
]
ASF GitHub Bot commented on CB-12286:
-------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/9
CB-12286 Tests reworked
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
All
### What does this PR do?
https://issues.apache.org/jira/browse/CB-12286
Tests now actually verify the plugin's methods and properties instead of
the native built-in ones.
### What testing has been done on this change?
Paramedic run on Android and Windows.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-screen-orientation
CB-12286
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
----
commit cd2ee4666d66190424df4efc9291c31be6d4781b
Author: Alexander Sorokin <[email protected]>
Date: 2016-12-21T11:46:01Z
CB-12286 Tests reworked
----
> Screen Orientation plugin's tests should actually test the plugin
> -----------------------------------------------------------------
>
> Key: CB-12286
> URL: https://issues.apache.org/jira/browse/CB-12286
> Project: Apache Cordova
> Issue Type: Test
> Components: Plugin Screen Orientation
> Affects Versions: Master
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> As of now, they test built-in {{window.orientation}} object while the plugin
> provides {{window.screen.orientation}} object.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
