[
https://issues.apache.org/jira/browse/CB-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872841#comment-15872841
]
ASF GitHub Bot commented on CB-12021:
-------------------------------------
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101877578
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -414,13 +414,15 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions) {
// it does not satisfy.
if(parsedSpec.version) {
if(pkgJson && pkgJson.dependencies &&
pkgJson.dependencies[parsedSpec.package]) {
- var noSymbolVersion;
+ var noSymbolVersion = parsedSpec.version;
if (parsedSpec.version.charAt(0) === '^' ||
parsedSpec.version.charAt(0) === '~') {
noSymbolVersion = parsedSpec.version.slice(1);
}
- if (!semver.satisfies(noSymbolVersion,
pkgJson.dependencies[parsedSpec.package])) {
+ if (pkgJson.dependencies[parsedSpec.package] ===
parsedSpec.version) {
pkgJson.dependencies[parsedSpec.package] =
parsedSpec.version;
- fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson,
null, 4), 'utf8');
+ if (fetchOptions.save === true) {
--- End diff --
this is good!
> --fetch should use dependency version saved in package.json before default
> cordova version when adding/restoring
> ----------------------------------------------------------------------------------------------------------------
>
> Key: CB-12021
> URL: https://issues.apache.org/jira/browse/CB-12021
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch, CordovaLib
> Reporter: Steve Gill
> Assignee: Audrey So
> Labels: cordova-7.0.0
> Fix For: 7.0.0
>
>
> cordova platform add android --save --fetch should use the version of
> cordova-android already saved in package.json instead of the version from
> platformsConfig.json
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
