[
https://issues.apache.org/jira/browse/CB-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875085#comment-15875085
]
ASF GitHub Bot commented on CB-12021:
-------------------------------------
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r102099272
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -412,15 +412,26 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions) {
// If parsedSpec.version satisfies pkgJson version, no writing to
pkg.json. Only write when
// it does not satisfy.
+
if(parsedSpec.version) {
if(pkgJson && pkgJson.dependencies &&
pkgJson.dependencies[parsedSpec.package]) {
- var noSymbolVersion;
+ var noSymbolVersion = parsedSpec.version;
if (parsedSpec.version.charAt(0) === '^' ||
parsedSpec.version.charAt(0) === '~') {
noSymbolVersion = parsedSpec.version.slice(1);
}
- if (!semver.satisfies(noSymbolVersion,
pkgJson.dependencies[parsedSpec.package])) {
+
+ if(cordova_util.isUrl(parsedSpec.version) ||
cordova_util.isDirectory(parsedSpec.version)) {
--- End diff --
How does this look (lines 423- 437)? @stevengill
> --fetch should use dependency version saved in package.json before default
> cordova version when adding/restoring
> ----------------------------------------------------------------------------------------------------------------
>
> Key: CB-12021
> URL: https://issues.apache.org/jira/browse/CB-12021
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch, CordovaLib
> Reporter: Steve Gill
> Assignee: Audrey So
> Labels: cordova-7.0.0
> Fix For: 7.0.0
>
>
> cordova platform add android --save --fetch should use the version of
> cordova-android already saved in package.json instead of the version from
> platformsConfig.json
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
