[
https://issues.apache.org/jira/browse/CB-12529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893224#comment-15893224
]
jcesarmobile commented on CB-12529:
-----------------------------------
Why should we do that?
If we don't know the connection, it should be unknown.
There are a lot of types of Android devices that don't have cellular
connection, and even phones can work without cellular connection. I don't see
the point of making the plugin return cellular when the type is unknown
> Support default 'cellular' detection into cordova-plugin-network-information
> for Android
> ----------------------------------------------------------------------------------------
>
> Key: CB-12529
> URL: https://issues.apache.org/jira/browse/CB-12529
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Reporter: Zia Sergio
>
> cordova-plugin-network-information/src/android/NetworkManager java class :
> Method getType() : In case of unknown cellular network detected, returned
> value is TYPE_UNKNOWN (equals "unknown" string)
> It seems it is better in this case that returns "cellular" string.
> For this simply add a constant :
> public static final String TYPE_CELL = "cellular";
> And add a 'else' statement after all 'else if' statements detecting the
> cellular connection sub-types :
> else {
> return TYPE_CELL;
> }
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
