[
https://issues.apache.org/jira/browse/CB-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954204#comment-15954204
]
ASF GitHub Bot commented on CB-12592:
-------------------------------------
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/536#discussion_r109532730
--- Diff: cordova-lib/src/cordova/metadata/ubuntu_parser.js ---
@@ -109,8 +110,8 @@ ubuntu_parser.prototype.update_manifest = function() {
content += '\nIcon=qmlscene';
console.warn('missing icon element in config.xml');
}
- fs.writeFileSync(path.join(this.path, 'manifest.json'),
JSON.stringify(manifest));
- fs.writeFileSync(path.join(this.path, 'cordova.desktop'), content);
--- End diff --
Would you replace this with packageManager.save or just in cases when
JSON.stringify is used??
> Refactor and add delete require.cache to cordova_util and create pkgManager
> ---------------------------------------------------------------------------
>
> Key: CB-12592
> URL: https://issues.apache.org/jira/browse/CB-12592
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
> Reporter: Audrey So
> Assignee: Audrey So
> Priority: Minor
> Labels: 7.0.0
>
> There are 120 instances of delete require.cache in cordova-lib. It should be
> refactored and added to cordova_util so it can be reused when needed. Package
> manager should also be created to load and save pkgJson files. Package
> manager loads files without require so that there is never a cache and saves
> stringified object to file.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
