[jira] [Commented] (CB-12592) Refactor and add delete require.cache to cordova_util and create pkgManager

Mon, 03 Apr 2017 15:08:22 -0700 

    [ 
https://issues.apache.org/jira/browse/CB-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954226#comment-15954226
 ] 

ASF GitHub Bot commented on CB-12592:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/536
  
    # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=h1) 
Report
    > Merging 
[#536](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/465185b88d015341d766b7921e18f8d37feef225?src=pr&el=desc)
 will **decrease** coverage by `0.39%`.
    > The diff coverage is `88.09%`.
    
    [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-lib/pull/536/graphs/tree.svg?token=KwBjKMXLqA&src=pr&height=150&width=650)](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff            @@
    ##           master     #536     +/-   ##
    =========================================
    - Coverage   82.78%   82.39%   -0.4%     
    =========================================
      Files          65       69      +4     
      Lines        5431     5469     +38     
      Branches     1067     1070      +3     
    =========================================
    + Hits         4496     4506     +10     
    - Misses        935      963     +28
    ```
    
    
    | [Impacted 
Files](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree) | 
Coverage Δ | |
    |---|---|---|
    | 
[cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=)
 | `78.08% <100%> (ø)` | |
    | 
[cordova-lib/src/plugman/util/metadata.js](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vdXRpbC9tZXRhZGF0YS5qcw==)
 | `85.29% <100%> (+0.44%)` | :arrow_up: |
    | 
[cordova-lib/src/plugman/platforms/ios.js](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL2lvcy5qcw==)
 | `82.16% <100%> (ø)` | :arrow_up: |
    | 
[cordova-lib/src/cordova/restore-util.js](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcmVzdG9yZS11dGlsLmpz)
 | `95.6% <100%> (ø)` | :arrow_up: |
    | 
[cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==)
 | `97.27% <100%> (ø)` | |
    | 
[cordova-lib/src/plugman/registry/manifest.js](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcmVnaXN0cnkvbWFuaWZlc3QuanM=)
 | `92.5% <100%> (ø)` | :arrow_up: |
    | 
[cordova-lib/src/cordova/platform\_metadata.js](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm1fbWV0YWRhdGEuanM=)
 | `88.88% <100%> (ø)` | :arrow_up: |
    | 
[cordova-lib/src/cordova/package\_manager.js](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGFja2FnZV9tYW5hZ2VyLmpz)
 | `66.66% <66.66%> (ø)` | |
    | 
[cordova-lib/src/cordova/plugin.js](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGx1Z2luLmpz)
 | `89.41% <71.42%> (-0.08%)` | :arrow_down: |
    | 
[cordova-lib/src/cordova/config.js](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvY29uZmlnLmpz)
 | `75% <0%> (-1.2%)` | :arrow_down: |
    | ... and [26 
more](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=tree-more) | |
    
    ------
    
    [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=continue).
    > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=footer). 
Last update 
[465185b...772238d](https://codecov.io/gh/apache/cordova-lib/pull/536?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


> Refactor and add delete require.cache to cordova_util and create pkgManager
> ---------------------------------------------------------------------------
>
>                 Key: CB-12592
>                 URL: https://issues.apache.org/jira/browse/CB-12592
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-lib
>            Reporter: Audrey So
>            Assignee: Audrey So
>            Priority: Minor
>              Labels: 7.0.0
>
> There are 120 instances of delete require.cache in cordova-lib. It should be 
> refactored and added to cordova_util so it can be reused when needed. Package 
> manager should also be created to load and save pkgJson files. Package 
> manager loads files without require so that there is never a cache and saves 
> stringified object to file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to