[
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969455#comment-15969455
]
ASF GitHub Bot commented on CB-8978:
------------------------------------
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/321#discussion_r111626815
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -401,6 +403,44 @@ function mapImageResources(rootDir, subDir, type,
resourceName) {
return pathMap;
}
+
+function updateFileResources(cordovaProject, platformDir) {
+ var files = cordovaProject.projectConfig.getFileResources('android');
+
+ // if there are resource-file elements in config.xml
+ if (files.length === 0) {
+ events.emit('verbose', 'This app does not have additional resource
files defined');
+ return;
+ }
+
+ var resourceMap = {};
+ files.forEach(function(res) {
+ var targetPath = path.join(platformDir, res.target);
+ resourceMap[targetPath] = res.src;
+ });
+
+ events.emit('verbose', 'Updating resource files at ' + platformDir);
+ FileUpdater.updatePaths(
+ resourceMap, { rootDir: cordovaProject.root }, logFileOp);
+}
+
+
+function cleanFileResources(projectRoot, projectConfig, platformDir) {
+ var files = projectConfig.getFileResources('android');
+ if (files.length > 0) {
--- End diff --
(same result in iOS in my PR)
> Adding <resource-file> tag support to config.xml
> ------------------------------------------------
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
> Issue Type: New Feature
> Components: CLI, CordovaLib
> Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
> Reporter: Karen Tran
> Assignee: Karen Tran
> Labels: config.xml, images
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that
> handles copying images from a source to destination in the config.xml. These
> elements also only handle copying 1 image only and replacing what was
> previously there as the icon.png or splash.png.
> I'm creating a new tag that will copy non-main app icon images, which could
> be notification icons, button icons, custom image text, etc. and not limited
> to just 1 image.
> Example:
> <image src="res/android/notification.png" name="notification.png" />
> <image src="res/android/notification-mdpi.png" name="notification.png"
> density="mdpi" />
> The required attributes will be src and name.
> Depending on the directory that the image gets copied to, the width and
> height attribute may not be needed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
