[
https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978183#comment-15978183
]
ASF GitHub Bot commented on CB-8978:
------------------------------------
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-lib/pull/547
CB-8978: Add option to get resource-file from root
Step 1 of resolving the first issue mentioned in
https://github.com/apache/cordova-android/pull/321#issuecomment-294985346
Step 2 will be updating the `cleanFileResources` function to pass in the
new option.
This is needed for cleaning the resource-file targets, since they are at
the top level of the platform's config.xml.
/cc @shazron
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS, Android
### What does this PR do?
Provides an option to return `resource-file` tags from the top level of
config.xml, instead of only returning ones nested under a particular platform.
### What testing has been done on this change?
Added spec test to verify top-level resource-files are returned when the
option is specified.
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-lib resource-file-clean
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/547.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #547
----
commit 8a4dde1efa12d9bfc6f409ff6360e67e3a53b13f
Author: Darryl Pogue <[email protected]>
Date: 2017-04-21T06:45:12Z
CB-8978: Add option to get resource-file from root
This will be needed for cleaning the resource-file targets, since they
are at the top level of the platform's config.xml.
----
> Adding <resource-file> tag support to config.xml
> ------------------------------------------------
>
> Key: CB-8978
> URL: https://issues.apache.org/jira/browse/CB-8978
> Project: Apache Cordova
> Issue Type: New Feature
> Components: CLI, CordovaLib
> Affects Versions: Master
> Environment: Android, iOS, WP8, Windows, Blackberry
> Reporter: Karen Tran
> Assignee: Karen Tran
> Labels: config.xml, images
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that
> handles copying images from a source to destination in the config.xml. These
> elements also only handle copying 1 image only and replacing what was
> previously there as the icon.png or splash.png.
> I'm creating a new tag that will copy non-main app icon images, which could
> be notification icons, button icons, custom image text, etc. and not limited
> to just 1 image.
> Example:
> <image src="res/android/notification.png" name="notification.png" />
> <image src="res/android/notification-mdpi.png" name="notification.png"
> density="mdpi" />
> The required attributes will be src and name.
> Depending on the directory that the image gets copied to, the width and
> height attribute may not be needed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
