[
https://issues.apache.org/jira/browse/CB-12856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025611#comment-16025611
]
ASF GitHub Bot commented on CB-12856:
-------------------------------------
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/313
CB-12856 - Skip CocoaPods check_reqs if on non-darwin (macOS) platform
**WORK IN PROGRESS**
### Platforms affected
self
### What does this PR do?
Ignore CocoaPods check and installation on non-darwin (macOS) platforms.
### What testing has been done on this change?
Work In Progress. No testing has been done yet, pending.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-12856
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #313
----
commit e27ece386d7dd9bf753053f804e215dcdb844336
Author: Shazron Abdullah <[email protected]>
Date: 2017-05-26T00:41:29Z
CB-12856 - Skip CocoaPods check_reqs if on non-darwin (macOS) platform
----
> Skip CocoaPods check_reqs if on non-darwin (macOS) platform
> -----------------------------------------------------------
>
> Key: CB-12856
> URL: https://issues.apache.org/jira/browse/CB-12856
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Fix For: [email protected]
>
>
> For example, phonegap-plugin-push can be installed on Windows, but if you
> have the cordova-ios platform installed as well on Windows, it will fail the
> check_reqs CocoaPods check.
> Make the check_reqs CocoaPods check only fail with the additional requirement
> that the platform is darwin (macOS). So if CocoaPods check fails, and the
> platform is non-darwin (Windows, Linux), check_reqs passes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
