[
https://issues.apache.org/jira/browse/CB-12856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027351#comment-16027351
]
ASF GitHub Bot commented on CB-12856:
-------------------------------------
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/313
CI all green, and my tests below all succeed. Squashing.
Tested on macOS Sierra 10.12.5 (node 4, 6): SUCCESS
- [X] CocoaPods not installed, should output error to install it
- [X] CocoaPods not synced, should output error to `pod sync`
- [X] Once installed, made sure it built for device properly
Tested on Windows 10 (node 4, 6): SUCCESS
- [X] CocoaPods not installed, should **not** output error to install it
- ~[ ] CocoaPods not synced, should **not** output error to `pod sync`~
Tested on Linux (Ubuntu 16, node 4, 6): SUCCESS
- [x] CocoaPods not installed, should **not** output error to install it
- ~[ ] CocoaPods not synced, should **not** output error to `pod sync`~
> Skip CocoaPods check_reqs if on non-darwin (macOS) platform
> -----------------------------------------------------------
>
> Key: CB-12856
> URL: https://issues.apache.org/jira/browse/CB-12856
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Fix For: [email protected]
>
>
> For example, phonegap-plugin-push can be installed on Windows, but if you
> have the cordova-ios platform installed as well on Windows, it will fail the
> check_reqs CocoaPods check.
> Make the check_reqs CocoaPods check only fail with the additional requirement
> that the platform is darwin (macOS). So if CocoaPods check fails, and the
> platform is non-darwin (Windows, Linux), check_reqs passes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
