[
https://issues.apache.org/jira/browse/CB-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052425#comment-16052425
]
ASF GitHub Bot commented on CB-12901:
-------------------------------------
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-cli/pull/282
CB-12901: removed .raw from cordova-lib calls
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-cli CB-12901
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/282.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #282
----
commit a4c71847702793fc24cdfe393f954e4b2f1fc863
Author: Steve Gill <[email protected]>
Date: 2017-06-16T21:37:07Z
CB-12901: removed .raw from cordova-lib calls
----
> Remove lazy loading of node modules from cordova tooling
> --------------------------------------------------------
>
> Key: CB-12901
> URL: https://issues.apache.org/jira/browse/CB-12901
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-common, cordova-lib
> Reporter: Filip Maj
> Assignee: Filip Maj
>
> There are various {{addProperty*}} methods that execute {{require}} at
> runtime. While this improves load time and only loads modules that are
> necessary, it also makes it harder to test, as spying and mocking is more
> difficult.
> The 300ms load time improvement, in the best case, is not worth the
> difficulty in writing unit tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
