[
https://issues.apache.org/jira/browse/CB-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055168#comment-16055168
]
ASF GitHub Bot commented on CB-12901:
-------------------------------------
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-cli/pull/283
CB-12901 Cli Refactor
### What does this PR do?
- fixed failing tests.
- adjusted tests to call cordova instead of cordova.raw
- added tests to compare cordova.raw and cordova
- changed some console.log to logger.log
- help module returns help text and does not print it
-- this is to make testing easier and not have it spit all over jasmine
output.
- various minor refactors, removed some un-needed promises etc.
- added timeoutInSecs property to make user prompts testable without
waiting for 30 seconds
- this includes @stevengill 's previous pr
### Platforms affected
tooling
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-cli RefactorWithCB-12901
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #283
----
commit a4c71847702793fc24cdfe393f954e4b2f1fc863
Author: Steve Gill <[email protected]>
Date: 2017-06-16T21:37:07Z
CB-12901: removed .raw from cordova-lib calls
commit a24ec7968f4b271d9c3487980d29b3766b690053
Author: Jesse MacFadyen <[email protected]>
Date: 2017-06-20T05:17:56Z
fixed lines that were too long, test was failing
commit a26a73a420f71c972094513580921070a9026a47
Author: Jesse MacFadyen <[email protected]>
Date: 2017-06-20T05:19:06Z
added timeoutInSecs property to make user prompts testable without waiting
for 30 seconds
commit 310d6b0a1c33d2289b8909fc61d13b46c7ca5950
Author: Jesse MacFadyen <[email protected]>
Date: 2017-06-20T05:22:13Z
adjusted tests to call cordova instead of cordova.raw, added tests to
compare cordova.raw and cordova, changed some console.log to logger.log; help
module returns help text and does not print it, this is to make testing easier
and not have it spit all over jasmine output. various minor refactors, removed
some un-needed promises
----
> Remove lazy loading of node modules from cordova tooling
> --------------------------------------------------------
>
> Key: CB-12901
> URL: https://issues.apache.org/jira/browse/CB-12901
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-common, cordova-lib
> Reporter: Filip Maj
> Assignee: Filip Maj
>
> There are various {{addProperty*}} methods that execute {{require}} at
> runtime. While this improves load time and only loads modules that are
> necessary, it also makes it harder to test, as spying and mocking is more
> difficult.
> The 300ms load time improvement, in the best case, is not worth the
> difficulty in writing unit tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
