[ 
https://issues.apache.org/jira/browse/CB-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054534#comment-16054534
 ] 

ASF GitHub Bot commented on CB-12804:
-------------------------------------

Github user macdonst commented on a diff in the pull request:

    https://github.com/apache/cordova-browser/pull/32#discussion_r122786300
  
    --- Diff: bin/template/www/manifest.json ---
    @@ -0,0 +1,21 @@
    +{
    +  "name": "My App",
    +  "short_name":"My Ap",
    +  "description": "Description of your app from template",
    +  "start_url": "index.html",
    +  "scope":"index.html",
    +  "icons": [{
    +    "src": "img/logo.png",
    +    "sizes": "192x192",
    +    "type": "image/png"
    +  }, {
    +    "src": "img/splash.png",
    --- End diff --
    
    I don't think we need the splash in the list of icons. Chrome will use the 
background_color, short_name and icon closest to 128dp to create a splash 
screen.


> Cordova-browser PWA needs a manifest file
> -----------------------------------------
>
>                 Key: CB-12804
>                 URL: https://issues.apache.org/jira/browse/CB-12804
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-browser
>            Reporter: Audrey So
>            Assignee: Audrey So
>             Fix For: cordova7
>
>
> Cordova-browser PWA needs a manifest file.
> This manifest.json file should get created during cordova platform add 
> browser and use values from config.xml to build.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to