[
https://issues.apache.org/jira/browse/CB-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064067#comment-16064067
]
ASF GitHub Bot commented on CB-12804:
-------------------------------------
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-browser/pull/36
CB-12804 Fixes some simple details - manifest.json
### Platforms affected
browser
### What does this PR do?
addresses issues raised with pr #32
### What testing has been done on this change?
manual testing
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-browser CB-12804-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-browser/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit 7aa99f6f19ec8cf4be4136242e42d36cb6ec460b
Author: Jesse MacFadyen <[email protected]>
Date: 2017-06-27T01:07:20Z
Approach cache more defensively
commit b7ac532a06f3aea72bb45d5e6b8c7c36ed48cbcd
Author: Jesse MacFadyen <[email protected]>
Date: 2017-06-27T01:08:21Z
use white as default bgcolor in manifest, map unknown orientation values to
'any', address some issues raised in #32
----
> Cordova-browser PWA needs a manifest file
> -----------------------------------------
>
> Key: CB-12804
> URL: https://issues.apache.org/jira/browse/CB-12804
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-browser
> Reporter: Audrey So
> Assignee: Audrey So
> Fix For: cordova7
>
>
> Cordova-browser PWA needs a manifest file.
> This manifest.json file should get created during cordova platform add
> browser and use values from config.xml to build.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
