[
https://issues.apache.org/jira/browse/CB-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056310#comment-16056310
]
ASF GitHub Bot commented on CB-12937:
-------------------------------------
GitHub user Giorgioshooter opened a pull request:
https://github.com/apache/cordova-ios/pull/321
CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno…
…tation in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
adds a new public method handleOpenURLWithApplicationSourceAndAnnotation in
CDVPlugin which contains the URL the applicationSource and annotation
### What testing has been done on this change?
Run test suite for cordova-ios
tested on an example app to make sure that the original handleOpenURL.
I did not find any tests on CDVPlugin
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Giorgioshooter/cordova-ios
CB-12937-handleOpenURL-with-applicationSource-and-annotation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/321.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #321
----
commit f49771bfa084b1b64965ee97a3b4afbf407693c3
Author: Georgios Galatoulas <[email protected]>
Date: 2017-06-20T12:35:40Z
CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation
in CDVPlugin and new notification id
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which is
broadcasted from CDVAppDelegate openURL method.
----
> [iOS] Add new CDVPlugin method to handle incoming urls including
> sourceApplication and annotation
> -------------------------------------------------------------------------------------------------
>
> Key: CB-12937
> URL: https://issues.apache.org/jira/browse/CB-12937
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
> Affects Versions: [email protected]
> Reporter: Georgios Galatoulas
> Assignee: Shazron Abdullah
> Labels: easy-fix
>
> The App is currently using the
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
> sourceApplication:(NSString*)sourceApplication
> annotation:(id)annotation{code}
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification
> contains only the url.
> I would like to add alongside the current notification a new notification
> which posts a NSDictionary instead that contains the url, sourceApplication
> and annotation and if makes sense I would also like create a new method like
> the current handleOpenURL which will provide the NSDictionary to however
> wants to use.
> I propose this solution because it does not introduce any breaking changes. I
> hope the impact is small and easy to add to the next release. *The work is
> already done in my local fork I will just need to create a branch and ask for
> a pull request if everyone is happy to proceed*.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
