[
https://issues.apache.org/jira/browse/CB-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056374#comment-16056374
]
ASF GitHub Bot commented on CB-12937:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/321
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/321?src=pr&el=h1)
Report
> Merging
[#321](https://codecov.io/gh/apache/cordova-ios/pull/321?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-ios/commit/4490abf273ec6d12810c8ff5ea16d197c58ecd4b?src=pr&el=desc)
will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/321?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #321 +/- ##
=======================================
Coverage 63.77% 63.77%
=======================================
Files 14 14
Lines 1623 1623
Branches 277 277
=======================================
Hits 1035 1035
Misses 588 588
```
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/321?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/321?src=pr&el=footer).
Last update
[4490abf...f49771b](https://codecov.io/gh/apache/cordova-ios/pull/321?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> [iOS] Add new CDVPlugin method to handle incoming urls including
> sourceApplication and annotation
> -------------------------------------------------------------------------------------------------
>
> Key: CB-12937
> URL: https://issues.apache.org/jira/browse/CB-12937
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
> Affects Versions: [email protected]
> Reporter: Georgios Galatoulas
> Assignee: Shazron Abdullah
> Labels: easy-fix
>
> The App is currently using the
> {code}- (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
> sourceApplication:(NSString*)sourceApplication
> annotation:(id)annotation{code}
> to handle incoming URLs.
> However the notification posted with id CDVPluginHandleOpenURLNotification
> contains only the url.
> I would like to add alongside the current notification a new notification
> which posts a NSDictionary instead that contains the url, sourceApplication
> and annotation and if makes sense I would also like create a new method like
> the current handleOpenURL which will provide the NSDictionary to however
> wants to use.
> I propose this solution because it does not introduce any breaking changes. I
> hope the impact is small and easy to add to the next release. *The work is
> already done in my local fork I will just need to create a branch and ask for
> a pull request if everyone is happy to proceed*.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
