[
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057371#comment-16057371
]
ASF GitHub Bot commented on CB-3232:
------------------------------------
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/565
Platform's spec is ignored in config.xml if package.json doesn't contain
dependency for platform
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
all
### What does this PR do?
Steps to reproduce with [email protected]:
1) Create app with package.json contains empty dependencies object:
`"dependencies": {}`
(e.g. it's default for Visual Studio Cordova template)
2) Add entry into config.xml: `<engine name="windows"
spec="https://github.com/apache/cordova-windows.git#4.4.x"; />`
3) `cordova platform add windows`
So, if package.json dependencies keys don't include `windows or
`cordova-windows`, we should look for a spec in config.xml.
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-lib
fix-platform-installation-from-spec
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/565.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #565
----
commit 2e5e18e52feab3be734d6ffc102f84baaf90ae10
Author: Nikita Matrosov <[email protected]>
Date: 2017-06-21T11:27:53Z
Platform's spec is ignored in config.xml if package.json doesn't contain
dependency for platform
----
> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>
> Key: CB-3232
> URL: https://issues.apache.org/jira/browse/CB-3232
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-blackberry (DEPRECATED), cordova-cli
> Affects Versions: 2.7.0
> Reporter: Michael Brooks
> Assignee: Michael Brooks
> Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating
> BlackBerry project...
> Updating config.xml ...
> sed:
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
> No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application
> directory!
> ]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
