[ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072610#comment-16072610
 ] 

ASF GitHub Bot commented on CB-3232:
------------------------------------

GitHub user seeday opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/91

    Avoid concurrent modification on callbacks list.

    Had been getting fast enumeration concurrent modification exceptions from 
what seems to be a race condition. Enumeration is slightly smarter when looping 
backwards.
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Fixes a fast enumeration crash
    
    ### What testing has been done on this change?
    Not quite sure how to run the testing suite, but it seems to work
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/seeday/cordova-plugin-geolocation master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #91
    
----
commit 80bbe9ce885a9b2b8796abedd1b6b66381bb3bb0
Author: Chris Day <[email protected]>
Date:   2017-06-13T17:45:43Z

    Avoid concurrent modification on callbacks list.
    
    Doesn't quite prevent it, but should be way better.

----


> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>
>                 Key: CB-3232
>                 URL: https://issues.apache.org/jira/browse/CB-3232
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-blackberry (DEPRECATED), cordova-cli
>    Affects Versions: 2.7.0
>            Reporter: Michael Brooks
>            Assignee: Michael Brooks
>             Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to