[
https://issues.apache.org/jira/browse/CB-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065447#comment-16065447
]
Filip Maj commented on CB-12950:
--------------------------------
OK, you know what, I'm fine with leaving the plugin test in. It's low cost,
high value.
Suggestion: simplifying / combining the create e2e tests. Currently, we have
tests that check whether we can create projects with app names that contain
unicode without space, unicode with spaces, ascii without spaces, ascii with
spaces, ascii+unicode without spaces and ascii+unicode with spaces. Why not
just reduce this down to testing app names with ascii, unicode and spaces?
These tests are high cost in the sense each one takes 60-90 seconds (and
sometimes I actually see timeouts at 90 seconds). Reducing it down to the one
test would speed that up, and also be just as valuable as all the other tests,
except we do not differentiate / isolate down to the specific character set /
character that causes a potential issue.
Thoughts?
> test-build e2e tests in cordova-android not running in CI
> ---------------------------------------------------------
>
> Key: CB-12950
> URL: https://issues.apache.org/jira/browse/CB-12950
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
> Reporter: Filip Maj
> Assignee: Filip Maj
>
> Looks like because jasmine removed support for the CLI flag
> {{--captureExceptions}} in a minor version bump, the CI is no longer
> executing the {{test-build}} npm task, which runs e2e tests.
> Should probably:
> - fix this, but probably more importantly
> - look at whether these tests are needed? Running them is in the travis job
> description, but not in the appveyor one, which means we are not getting this
> test coverage on Windows in CI anyways.
> - perhaps the test coverage here can be provided by unit testing the CLI
> scripts more fully, rather than relying on e2e tests?
> Ping [~bowserj].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
