[ 
https://issues.apache.org/jira/browse/CB-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067115#comment-16067115
 ] 

Joe Bowser commented on CB-12950:
---------------------------------

[~filmaj] After looking over e2e, I have no idea why the create tests exist and 
aren't in the Unit tests.  We shouldn't be testing whether Android compiles, we 
should instead be testing whether we sanitize the project names so Android can 
compile.  The only test worth keeping is the one plugin test.

> test-build e2e tests in cordova-android not running in CI
> ---------------------------------------------------------
>
>                 Key: CB-12950
>                 URL: https://issues.apache.org/jira/browse/CB-12950
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android
>            Reporter: Filip Maj
>            Assignee: Filip Maj
>
> Looks like because jasmine removed support for the CLI flag 
> {{--captureExceptions}} in a minor version bump, the CI is no longer 
> executing the {{test-build}} npm task, which runs e2e tests.
> Should probably:
> - fix this, but probably more importantly
> - look at whether these tests are needed? Running them is in the travis job 
> description, but not in the appveyor one, which means we are not getting this 
> test coverage on Windows in CI anyways.
> - perhaps the test coverage here can be provided by unit testing the CLI 
> scripts more fully, rather than relying on e2e tests?
> Ping [~bowserj].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to