[
https://issues.apache.org/jira/browse/CB-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066065#comment-16066065
]
ASF GitHub Bot commented on CB-6143:
------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-lib/pull/572
CB-6143: Change plugman.emit() to events.emit()
### Platforms affected
all
### What does this PR do?
https://issues.apache.org/jira/browse/CB-6143
Changes remaining `plugman.emit()` calls to `events.emit()` for consistency
and to fix a build error when building a browserified app.
### What testing has been done on this change?
`npm test`, built an android app, built a browserified android app
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-lib CB-6143
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/572.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #572
----
commit e32371e767bd43a86d0f83201b1d473891525fb4
Author: Alexander Sorokin <[email protected]>
Date: 2017-06-28T07:28:58Z
CB-6143: Change plugman.emit() to events.emit()
----
> Change plugman.emit() to events.emit() for consitency
> -----------------------------------------------------
>
> Key: CB-6143
> URL: https://issues.apache.org/jira/browse/CB-6143
> Project: Apache Cordova
> Issue Type: Test
> Components: cordova-plugman
> Affects Versions: 3.3.0
> Reporter: Jonathan Bond
> Priority: Minor
> Fix For: Master
>
>
> A lot of code uses:
> require('../../plugman').emit()
> Refactoring to:
> events.emit()
> Improves readability and consistency in pluman & cli.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
