[
https://issues.apache.org/jira/browse/CB-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066085#comment-16066085
]
ASF GitHub Bot commented on CB-6143:
------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/572
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=h1)
Report
> Merging
[#572](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-lib/commit/d6fcbc3719e72085be75b03d68cec1bc7e5c162c?src=pr&el=desc)
will **not change** coverage.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #572 +/- ##
=======================================
Coverage 43.06% 43.06%
=======================================
Files 78 78
Lines 4361 4361
Branches 852 852
=======================================
Hits 1878 1878
Misses 2483 2483
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/plugman/browserify.js](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vYnJvd3NlcmlmeS5qcw==)
| `8.33% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=footer).
Last update
[d6fcbc3...e32371e](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> Change plugman.emit() to events.emit() for consitency
> -----------------------------------------------------
>
> Key: CB-6143
> URL: https://issues.apache.org/jira/browse/CB-6143
> Project: Apache Cordova
> Issue Type: Test
> Components: cordova-plugman
> Affects Versions: 3.3.0
> Reporter: Jonathan Bond
> Priority: Minor
> Fix For: Master
>
>
> A lot of code uses:
> require('../../plugman').emit()
> Refactoring to:
> events.emit()
> Improves readability and consistency in pluman & cli.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
