[
https://issues.apache.org/jira/browse/CB-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068023#comment-16068023
]
ASF GitHub Bot commented on CB-12963:
-------------------------------------
GitHub user halton opened a pull request:
https://github.com/apache/cordova-coho/pull/153
CB-12963: npm-link all dependencies
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/halton/cordova-coho CB-12963
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-coho/pull/153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #153
----
commit e13edb74b4703eb800444c48c5c22f2aa7168b81
Author: Halton Huo <[email protected]>
Date: 2017-06-29T08:45:52Z
CB-12963: npm-link all dependencies
----
> npm-link should resolve all dependencies as master
> --------------------------------------------------
>
> Key: CB-12963
> URL: https://issues.apache.org/jira/browse/CB-12963
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
> Reporter: Haitao Huo
>
> The latest
> [npm-link.js|https://github.com/apache/cordova-coho/blob/2296887cfcd0de95b38e6a1900eabf68d9731fe4/src/npm-link.js#L71-L91]
> code as below.
> {code}
> npmLinkOut("cordova-js");
> npmLinkIn("cordova-js", "cordova-lib");
> npmLinkOut("cordova-common");
> npmLinkIn("cordova-common", "cordova-fetch");
> npmLinkIn("cordova-common", "cordova-create");
> npmLinkIn("cordova-common", "cordova-lib");
> npmLinkIn("cordova-common", "cordova-cli");
> npmLinkOut("cordova-fetch");
> npmLinkIn("cordova-fetch", "cordova-lib");
> npmLinkOut("cordova-create");
> npmLinkIn("cordova-create", "cordova-lib");
> npmLinkOut("cordova-serve");
> npmLinkIn("cordova-serve", "cordova-lib");
> npmLinkOut("cordova-lib");
> npmLinkIn("cordova-lib", "cordova-plugman");
> npmLinkIn("cordova-lib", "cordova-cli");
> {code}
> If we looked dependencies like plugman, only cordova-lib is listed, actually
> cordova-common, cordova-create, cordova-fetch, cordova-js, cordova-lib, and
> cordova-serve are all in the dependency. The partial dependency will cause
> part use official code, part use master code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
