[ 
https://issues.apache.org/jira/browse/CB-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069560#comment-16069560
 ] 

ASF GitHub Bot commented on CB-12963:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-coho/pull/153


> npm-link should resolve all dependencies as master
> --------------------------------------------------
>
>                 Key: CB-12963
>                 URL: https://issues.apache.org/jira/browse/CB-12963
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-coho
>            Reporter: Haitao Huo
>
> The latest 
> [npm-link.js|https://github.com/apache/cordova-coho/blob/2296887cfcd0de95b38e6a1900eabf68d9731fe4/src/npm-link.js#L71-L91]
>  code as below.
> {code}
>     npmLinkOut("cordova-js");
>     npmLinkIn("cordova-js", "cordova-lib");
>     npmLinkOut("cordova-common");
>     npmLinkIn("cordova-common", "cordova-fetch");
>     npmLinkIn("cordova-common", "cordova-create");
>     npmLinkIn("cordova-common", "cordova-lib");
>     npmLinkIn("cordova-common", "cordova-cli");
>     npmLinkOut("cordova-fetch");
>     npmLinkIn("cordova-fetch", "cordova-lib");
>     npmLinkOut("cordova-create");
>     npmLinkIn("cordova-create", "cordova-lib");
>     npmLinkOut("cordova-serve");
>     npmLinkIn("cordova-serve", "cordova-lib");
>     npmLinkOut("cordova-lib");
>     npmLinkIn("cordova-lib", "cordova-plugman");
>     npmLinkIn("cordova-lib", "cordova-cli");
> {code}
> If we looked dependencies like plugman, only cordova-lib is listed, actually 
> cordova-common, cordova-create, cordova-fetch, cordova-js, cordova-lib, and 
> cordova-serve are all in the dependency.  The partial dependency will cause 
> part use official code, part use master code. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to