[
https://issues.apache.org/jira/browse/CB-12975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082963#comment-16082963
]
ASF GitHub Bot commented on CB-12975:
-------------------------------------
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Hah! I haven't used GitHub UI to do this kinda stuff before, so I can only
tell you how to do it via the `git` command line tool.
By "rebase," I meant ensuring that the latest changes from this repository
are included in your patch. Right now, this PR is a couple of changes behind.
As for squashing commits / changing the commit message, I think if you
re-do your edits, that should end up being the same thing. Feel free to close
this pull request and open a new one.
I just want to ensure that:
a) There is only commit containing these changes and
b) The commit message is prefixed with the CB-12975 key
thanks again!
> Resort cordova.InAppBrowser.open `options` for better developer experience
> --------------------------------------------------------------------------
>
> Key: CB-12975
> URL: https://issues.apache.org/jira/browse/CB-12975
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-docs, cordova-plugin-inappbrowser
> Reporter: Jan Piotrowski
> Assignee: Filip Maj
> Priority: Minor
>
> Right now the list of `options` for `cordova.InAppBrowser.open` on
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-inappbrowser/
> for the three platforms with additional options is quite random. As a user
> it is quite simple to misunderstand the wording and list as e.g. `hidden`only
> being available for Android (first item in only the Android list, there
> "Android only" directly over the line.
> It would be great to resort them in a way, that it is easier to find out
> which of the options are available on all (or multiple) of the 3 platforms
> with additional options. Also the "only" could be reworded to be less
> "exclusive".
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
