[
https://issues.apache.org/jira/browse/CB-12975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109013#comment-16109013
]
ASF GitHub Bot commented on CB-12975:
-------------------------------------
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Thanks for the proper explanation! I almost understood it and went to work
with Sourcetree...
https://www.atlassian.com/blog/sourcetree/interactive-rebase-sourcetree
explains that interactive rebase is also possible with Sourcetree. But of
course I couldn't rebase at the beginning because I was working on my fork
which is not really connected to the apache repo any more.
So I did as you said and added the apache repo again (while having checked
out `patch-1`. This created this nice merge commit automatically:
https://github.com/janpio/cordova-plugin-inappbrowser/commit/3066febdc723c5d0d99ab458c92038fa2f064553
This seems to be what we wanted to "rebase" my commits, because now "This
branch is 3 commits ahead of apache:master. "
Via the "interactive rebase" feature of Sourcetree I could now "merge" my
initial commit and the whitespace commit. But then I somehow messed up, because
now the commits from the merge commit are in my branch as well, additionally to
that dumb merge commit in the first place...
Well, I have to investigate a bit more it seems ;)
> Resort cordova.InAppBrowser.open `options` for better developer experience
> --------------------------------------------------------------------------
>
> Key: CB-12975
> URL: https://issues.apache.org/jira/browse/CB-12975
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-docs, cordova-plugin-inappbrowser
> Reporter: Jan Piotrowski
> Assignee: Filip Maj
> Priority: Minor
>
> Right now the list of `options` for `cordova.InAppBrowser.open` on
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-inappbrowser/
> for the three platforms with additional options is quite random. As a user
> it is quite simple to misunderstand the wording and list as e.g. `hidden`only
> being available for Android (first item in only the Android list, there
> "Android only" directly over the line.
> It would be great to resort them in a way, that it is easier to find out
> which of the options are available on all (or multiple) of the 3 platforms
> with additional options. Also the "only" could be reworded to be less
> "exclusive".
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
