[
https://issues.apache.org/jira/browse/CB-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100809#comment-16100809
]
Filip Maj edited comment on CB-12730 at 7/25/17 9:22 PM:
---------------------------------------------------------
Scratch my previous comment, the behaviour I assumed with installing plugins,
and what happens when a dependent plugin's constraints cannot be satisfied, was
wrong. If a dependent plugin's requirements (via engine tags) are not met, that
plugin gets skipped (for the particular platform in which constraints are being
checked, if applicable). I assumed that any unmet constraints, at any point in
the dependency chain, for any platform, would cause the installation to
immediately stop. That's not the case.
Sounds like a different path forward would be (as explained to me by
[~macdonst]):
- add {{<engine name="cordova-android" version="<7.0.0">}} to
cordova-plugin-compat's {{plugin.xml}}
- do one final release with this included constraint to npm (does that deserve
a major bump?)
- leave cordova-plugin-compat as a dependency in the plugins that rely on it
today, but bump the version required to match the last released version (the
one that includes the engine constraint).
was (Author: filmaj):
Scratch my previous comment, the behaviour I assumed with installing plugins,
and what happens when a dependent plugin's constraints cannot be satisfied, was
wrong. If a dependent plugin's requirements (via engine tags) are not met, that
plugin gets skipped (for the particular platform in which constraints are being
checked, if applicable). I assumed that any unmet constraints, at any point in
the dependency chain, for any platform, would cause the installation to
immediately stop. That's not the case.
Sounds like a different path forward would be (as explained to me by
[~macdonst]):
- leave cordova-plugin-compat as a dependency in the plugins that rely on it
today
- add {{<engine name="cordova-android" version="<7.0.0">}} to
cordova-plugin-compat's {{plugin.xml}}
- do one final release with this included constraint to npm (does that deserve
a major bump?)
> Compat - INTEGRATE
> ------------------
>
> Key: CB-12730
> URL: https://issues.apache.org/jira/browse/CB-12730
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-plugin-compat
> Reporter: Shazron Abdullah
> Assignee: Simon MacDonald
>
> See parent issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
