[
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200748#comment-16200748
]
ASF GitHub Bot commented on CB-13424:
-------------------------------------
GitHub user JoseExposito opened a pull request:
https://github.com/apache/cordova-osx/pull/43
CB-13424: "cordova plugin add/remove" writes changes in config.xml
See https://issues.apache.org/jira/browse/CB-13424 and
https://github.com/apache/cordova-plugin-camera/pull/290 for a description of
the issue.
This PR allows to add/remove plugins to the config.xml.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoseExposito/cordova-osx master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-osx/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit c4b44ee1de415479a5d4a0da97988da18e786acd
Author: José Expósito <[email protected]>
Date: 2017-10-11T18:40:55Z
CB-13424: When running "cordova plugin add/remove" plugins are added and
removed properly to the osx platform config.xml file
----
> [cordova-osx] Not adding plugins to the osx platform
> ----------------------------------------------------
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-osx
> Reporter: José Expósito
> Assignee: Tobias Bocanegra
> Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> <?xml version='1.0' encoding='utf-8'?>
> <widget id="io.cordova.hellocordova" version="1.0.0"
> xmlns="http://www.w3.org/ns/widgets";
> xmlns:cdv="http://cordova.apache.org/ns/1.0";>
> [...]
> <feature name="Device">
> <param name="osx-package" value="CDVDevice" />
> </feature>
> [...]
> </widget>
> {code}
> I noticed this happens with Cordova core plugins with official macOS support
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
