[
https://issues.apache.org/jira/browse/CB-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207501#comment-16207501
]
ASF GitHub Bot commented on CB-13424:
-------------------------------------
Github user giuseppelt commented on a diff in the pull request:
https://github.com/apache/cordova-osx/pull/43#discussion_r145098266
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -199,8 +201,8 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
* CordovaError instance.
*/
Api.prototype.removePlugin = function (plugin, uninstallOptions) {
- var Plugman = require('./lib/plugman/Plugman');
- return Plugman.get(this.locations, this.events).removePlugin(plugin,
uninstallOptions);
+ var xcodeproj = projectFile.parse(this.locations);
+ return PluginManager.get(self.platform, self.locations,
xcodeproj).removePlugin(plugin, uninstallOptions)
--- End diff --
`self` is undefined here
replace with `this`
> [cordova-osx] Not adding plugins to the osx platform
> ----------------------------------------------------
>
> Key: CB-13424
> URL: https://issues.apache.org/jira/browse/CB-13424
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-osx
> Reporter: José Expósito
> Assignee: Tobias Bocanegra
> Priority: Blocker
>
> cordova plugin add does not work on macOS.
> It is necessary to open "platforms/osx/HelloCordova.xcodeproj" and manually
> add the plugin to "platforms/osx/HelloCordova/config.xml":
> {code}
> <?xml version='1.0' encoding='utf-8'?>
> <widget id="io.cordova.hellocordova" version="1.0.0"
> xmlns="http://www.w3.org/ns/widgets";
> xmlns:cdv="http://cordova.apache.org/ns/1.0";>
> [...]
> <feature name="Device">
> <param name="osx-package" value="CDVDevice" />
> </feature>
> [...]
> </widget>
> {code}
> I noticed this happens with Cordova core plugins with official macOS support
> like cordova-plugin-device or cordova-plugin-file.
> Also experimented while migrating cordova-plugin-camera:
> https://github.com/apache/cordova-plugin-camera/pull/290
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
