[
https://issues.apache.org/jira/browse/CB-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209842#comment-16209842
]
ASF GitHub Bot commented on CB-13451:
-------------------------------------
Github user OminousWater commented on the issue:
https://github.com/apache/cordova-lib/pull/597
@zaq962 if you apply the changes in my pull request (it's just one file) to
your local checkout, it should work fine. The only reason it doesn't pass the
continuous integration test is that 'package' is a reserved keyword, which
eslint doesn't like. I've been experimenting with fixing the problem on the
plugman side, by renaming the 'package' keyword there, which would be a better
fix arguably. If I get that working then I'll re-open the pull request against
the plugman source.
> "pkg not defined" exception when running plugman with createpackagejson
> command-line
> ------------------------------------------------------------------------------------
>
> Key: CB-13451
> URL: https://issues.apache.org/jira/browse/CB-13451
> Project: Apache Cordova
> Issue Type: Bug
> Reporter: Roland
> Priority: Minor
>
> NOTE: I am about to submit a pull request with a fix for this issue.
> Description follows:
> A global js-lint pass on the cordova-lib codebase on the 30/8/2017 caused
> references to the global 'package' variable in init-default.js to be renamed
> to 'pkg', presumably because the cordova-lib source doesn't declare a global
> variable called 'package' but _does_ declare a global variable called 'pkg'
> (in cordova/info.js). However in this case, the 'package' variable refers to
> the one declared in the plugman source, specifically main.js, so it should
> have stayed as 'package'. To test the fix, run:
> plugman createpackagejson .
> Without the fix, this will trigger the following exception: 'pkg is not
> defined'. Having patched in the fix, running the command line should work as
> expected, prompting the user with questions and then spitting out a
> package.json file.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
