[ 
https://issues.apache.org/jira/browse/CB-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210383#comment-16210383
 ] 

ASF GitHub Bot commented on CB-13451:
-------------------------------------

Github user stevengill commented on the issue:

    https://github.com/apache/cordova-lib/pull/597
  
    I think turning it back to `package` in plugman is the way to go. We can 
add an eslint exception for it I hope


> "pkg not defined" exception when running plugman with createpackagejson 
> command-line
> ------------------------------------------------------------------------------------
>
>                 Key: CB-13451
>                 URL: https://issues.apache.org/jira/browse/CB-13451
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Roland
>            Priority: Minor
>
> NOTE: I am about to submit a pull request with a fix for this issue. 
> Description follows:
> A global js-lint pass on the cordova-lib codebase on the 30/8/2017 caused 
> references to the global 'package' variable in init-default.js to be renamed 
> to 'pkg', presumably because the cordova-lib source doesn't declare a global 
> variable called 'package' but _does_ declare a global variable called 'pkg' 
> (in cordova/info.js). However in this case, the 'package' variable refers to 
> the one declared in the plugman source, specifically main.js, so it should 
> have stayed as 'package'. To test the fix, run:
>       plugman createpackagejson .
> Without the fix, this will trigger the following exception: 'pkg is not 
> defined'. Having patched in the fix, running the command line should work as 
> expected, prompting the user with questions and then spitting out a 
> package.json file.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to