[
https://issues.apache.org/jira/browse/CB-13580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254542#comment-16254542
]
ASF GitHub Bot commented on CB-13580:
-------------------------------------
DavidStrausz opened a new pull request #417: CB-13580: (android) fix build for
multiple apks (different product flavors)
URL: https://github.com/apache/cordova-android/pull/417
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
cordova-android
### What does this PR do?
This PR fixes the build if cdvBuildMultipleApks is set to true by defining
`flavorDimensions "default"` in `build.gradle` and by adapting the
`findOutputApksHelper` method in `GenericBuilder.js` to recursively scan the
`build/outputs/apk` directory for matching candidates.
### What testing has been done on this change?
I ran the unit tests and the connectedAndroidTest tests and did manual tests
of builds with crosswalk (multiple APKs) and builds without crosswalk (single
APK).
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> cordova-android 6.4.0 broke build if cdvBuildMultipleApks is set to true
> ------------------------------------------------------------------------
>
> Key: CB-13580
> URL: https://issues.apache.org/jira/browse/CB-13580
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
> Affects Versions: 6.4.0
> Reporter: David Strauß
> Assignee: Joe Bowser
> Labels: build
>
> With the latest cordova-android (6.4.0) builds for different product flavors
> (arm, x86) do not work anymore (error e.g.: "No flavor is associated with
> flavor dimension ...") because of the changes introduced with gradle 3.0.0.
> With the new gradle plugin a flavorDimenson must be specified to build
> different product flavors (mentioned
> [here|https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html?utm_source=android-studio#flavor_dimensions]
> in the upgrade guide. This can be fixed by adding `flavorDimensions
> "default"` to build.gradle if cdvBuildMultipleApks is set to true.
> Another change that was introduced with the new gradle version is that builds
> for different architectures are put into their own directory
> (build/outputs/apk/<arch>/<debug|release>) which results in APK files not
> being found (mentioned in the upgrade guide under the point "Modifying
> variant outputs at build time may not work").
> This can be fixed by adapting the findOutputApksHelper method in
> GenericBuilder.js.
> An unfortunate side effect of these issues is that projects leveraging
> crosswalk do not work anymore.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
