[
https://issues.apache.org/jira/browse/CB-13580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254579#comment-16254579
]
ASF GitHub Bot commented on CB-13580:
-------------------------------------
codecov-io commented on issue #417: CB-13580: (android) fix build for multiple
apks (different product flavors)
URL: https://github.com/apache/cordova-android/pull/417#issuecomment-344782111
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/417?src=pr&el=h1)
Report
> Merging
[#417](https://codecov.io/gh/apache/cordova-android/pull/417?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/3760616639eb8d264edc99c3b5c8794c4d378bc8?src=pr&el=desc)
will **decrease** coverage by `0.23%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-android/pull/417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #417 +/- ##
==========================================
- Coverage 44.01% 43.77% -0.24%
==========================================
Files 17 17
Lines 1679 1688 +9
Branches 304 306 +2
==========================================
Hits 739 739
- Misses 940 949 +9
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/417?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/417?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
| `27.5% <0%> (-3.49%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/417?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/417?src=pr&el=footer).
Last update
[3760616...5d99e50](https://codecov.io/gh/apache/cordova-android/pull/417?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> cordova-android 6.4.0 broke build if cdvBuildMultipleApks is set to true
> ------------------------------------------------------------------------
>
> Key: CB-13580
> URL: https://issues.apache.org/jira/browse/CB-13580
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
> Affects Versions: 6.4.0
> Reporter: David Strauß
> Assignee: Joe Bowser
> Labels: build
>
> With the latest cordova-android (6.4.0) builds for different product flavors
> (arm, x86) do not work anymore (error e.g.: "No flavor is associated with
> flavor dimension ...") because of the changes introduced with gradle 3.0.0.
> With the new gradle plugin a flavorDimenson must be specified to build
> different product flavors (mentioned
> [here|https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html?utm_source=android-studio#flavor_dimensions]
> in the upgrade guide. This can be fixed by adding `flavorDimensions
> "default"` to build.gradle if cdvBuildMultipleApks is set to true.
> Another change that was introduced with the new gradle version is that builds
> for different architectures are put into their own directory
> (build/outputs/apk/<arch>/<debug|release>) which results in APK files not
> being found (mentioned in the upgrade guide under the point "Modifying
> variant outputs at build time may not work").
> This can be fixed by adapting the findOutputApksHelper method in
> GenericBuilder.js.
> An unfortunate side effect of these issues is that projects leveraging
> crosswalk do not work anymore.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
