[
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342535#comment-16342535
]
ASF GitHub Bot commented on CB-13415:
-------------------------------------
jcesarmobile commented on issue #309: CB-13415 (android) Importing corrupt
images using the Camera plugin c…
URL:
https://github.com/apache/cordova-plugin-camera/pull/309#issuecomment-361055486
I've finally tested and the problem is only present when
`Camera.DestinationType.DATA_URL`, so I don't think the problem is the
corrupted image itself, but the common out of memory problem when using
DATA_URL. The sample image is 4MB, that shouldn't be a problem, but maybe being
corrupted increase the memory needed to handle it.
In the docs you can read:
> NOTE: Photo resolution on newer devices is quite good. Photos selected
from the device's gallery are not downscaled to a lower quality, even if a
quality parameter is specified. To avoid common memory problems, set
Camera.destinationType to FILE_URI rather than DATA_URL.
So, I don't think you should hardcode the OutOfMemoryError to corrupted
image as any big image not corrupted will also cause the OutOfMemoryError.
So, @infil00p do you think we should hardcode it to something else? or just
return the `e.getMessage()` or `e.getLocalizedMessage()`?
The truth is the messages returned are not very helpful, is "failed to
allocate xxxx byte allocation with yyyy free bytes and zzMB until OOM"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Importing corrupt images using the Camera plugin crashes the app
> ----------------------------------------------------------------
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
> Reporter: Shemrick Flannigan
> Priority: Critical
> Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app |
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner
> class to prevent an app crash |
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes]
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
